Skip to content

Pre-existing test failures: Fortnite + CSGO pipeline mocks #5

Description

@safiqsindha

Summary

9 test failures in tests/test_pipelines_real_fetch.py that pre-date the v5 Phase D closeout. Documenting here so anyone running CI fresh on main knows they're not introduced by recent work.

Failures

tests/test_pipelines_real_fetch.py::TestCSGORealFetch::test_fetch_skips_existing_json
tests/test_pipelines_real_fetch.py::TestCSGORealFetch::test_fetch_downloads_match_stats
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_fetch_auth_failure_returns_empty
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_fetch_expired_replay_skipped
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_fetch_writes_json_on_success
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_fetch_skips_existing_file
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_parse_loads_json_file
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_parse_skips_corrupt_file
tests/test_pipelines_real_fetch.py::TestFortniteRealFetch::test_extract_events_from_event_chunks

Run: 415 passed, 9 failed.

Provenance

git log --oneline -- src/cells/csgo/pipeline.py tests/test_pipelines_real_fetch.py last touched in commit 6f2f3d2 (PUBG cell + poker corpus swap, A2/A3 era). All failures pre-date the Phase D closeout commits (be84525 through c163529).

Root cause (untriaged)

  • Fortnite: Per A2/D-35, Fortnite was replaced by PUBG. The Fortnite pipeline at src/cells/fortnite/ is no longer on the active code path but the test file still exists and fails. Likely a stale mock contract from before the swap.
  • CSGO: test_fetch_skips_existing_json and test_fetch_downloads_match_stats both expect pipeline.fetch() to return non-empty paths but get []. Probably a mock-vs-implementation mismatch in the FACEIT API stub.

Why this isn't blocking v5

  • The pipelines all worked end-to-end during Phase D (5 cells × n=1,200 chains × real data). The failures are in mocked unit tests, not integration.
  • v5 results are locked (Phase D, n=1,200, 4/5 cells significant past Bonferroni). The unit-test failures don't affect any published number.
  • Fortnite is on the dead code path per A2.

Suggested fix

Two options, in order of cleanliness:

  1. Delete the Fortnite tests entirely, since src/cells/fortnite/ should also probably be deleted (it's been on the dead code path since A2 in commit 6f2f3d2). Quick + removes a maintenance liability.
  2. Re-record the mock contracts for both cells so the tests reflect current implementation. Slower, only worth it if Fortnite stays in the tree.

If neither is done before v5.1 cross-model work begins, just --deselect these two test classes in CI.

Reference

  • Closeout commit: c163529 (tag v5.0)
  • See STATUS.md for v5 final state
  • See DECISION_LOG.md D-35 for the Fortnite → PUBG swap rationale

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions