Make the typecheck run, and keep it running

tsconfig set `baseUrl: "."`, which TypeScript 6 rejects outright, so
`tsc --noEmit` died before reading a single file -- the typecheck had
been off for as long as the option has been deprecated, and nobody saw
an error because there was no output to see. `paths` has not needed
`baseUrl` since TypeScript 5; the entries are now tsconfig-relative.

With tsc actually running, 14 errors appeared. Twelve were one cause:
the Worker surface had no Cloudflare types at all, so `D1Database`,
`R2Bucket`, `ExportedHandler` and `cloudflare:workers` were unresolved.
`wrangler types` generates them; the output is committed because the
typecheck cannot run without it. Regenerating twice produces an
identical file, so CI can diff it -- a stale copy now fails the build
instead of quietly weakening the check.

The other two: base64UrlToBytes was declared as bare `Uint8Array`, which
widens to `ArrayBufferLike` and so admits SharedArrayBuffer, while
crypto.subtle.verify wants an ArrayBuffer-backed view. The runtime value
was always ArrayBuffer-backed; only the declaration was loose. And the
astro:config:setup hook parameter got a JSDoc type.

`npm run typecheck` now exists, quality.yml runs it, and `npm run
quality` covers tests + typecheck + build. Without the CI step this
would have rotted back to zero the same silent way.

212 tests pass, 0 type errors, both builds complete.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: sametbasbug

.github/workflows/quality.yml

@@ -44,6 +44,23 @@ jobs:
       - name: Install Node dependencies
         run: npm ci
 
+      # `worker-configuration.d.ts` üretilmiş bir dosya ama depoda duruyor:
+      # tür kontrolü onsuz `D1Database`, `R2Bucket` ve `ExportedHandler`ı
+      # bulamıyor. Depodaki kopya `wrangler.ssr.jsonc` değiştiğinde sessizce
+      # bayatlayabilir; bu adım yeniden üretip fark varsa düşüyor.
+      - name: Check the generated Worker types are current
+        run: |
+          cp worker-configuration.d.ts /tmp/worker-types-committed.d.ts
+          npm run types:gen
+          diff --unified /tmp/worker-types-committed.d.ts worker-configuration.d.ts \
+            || { echo 'worker-configuration.d.ts bayat: `npm run types:gen` çalıştırıp commit edin.' >&2; exit 1; }
+
+      # Tür kontrolü 2026-08-21'e kadar HİÇ koşmuyordu: tsconfig'deki
+      # deprecated `baseUrl` TS 6'da hata verip tsc'yi daha başlamadan
+      # düşürüyordu. Kaldırıldığında 14 gerçek hata çıktı.
+      - name: Typecheck
+        run: npm run typecheck
+
       - name: Build Astro site
         env:
           PUBLIC_SITE_URL: https://haber.sametbasbug.dev

astro.config.ssr.mjs

@@ -23,6 +23,7 @@ function yayinUclari() {
   return {
     name: 'haber-yayin-uclari',
     hooks: {
+      /** @param {{ injectRoute: (route: { pattern: string, entrypoint: string }) => void }} ctx */
       'astro:config:setup': ({ injectRoute }) => {
         injectRoute({ pattern: '/api/brief', entrypoint: './src/server/routes/brief.ts' });
         injectRoute({ pattern: '/api/publish', entrypoint: './src/server/routes/publish.ts' });

package.json

@@ -18,6 +18,8 @@
     "build": "astro build",
     "build:ssr": "astro build --config astro.config.ssr.mjs",
     "deploy": "wrangler deploy --config wrangler.ssr.jsonc",
+    "typecheck": "tsc --noEmit -p tsconfig.json",
+    "types:gen": "wrangler types --config wrangler.ssr.jsonc",
     "preview": "astro preview",
     "astro": "astro",
     "ozet:new": "node scripts/new-gunluk-ozet.mjs",
@@ -27,7 +29,7 @@
     "haber:ayna": "node scripts/haber-ayna.mjs",
     "haber:ayna:kuru": "node scripts/haber-ayna.mjs --kuru",
     "test:newsroom": "newsroom/.venv/bin/python -m pytest newsroom/tests",
-    "quality": "npm run test:newsroom && npm run build"
+    "quality": "npm run test:newsroom && npm run typecheck && npm run build"
   },
   "dependencies": {
     "@astrojs/markdown-remark": "^7.2.4",

tsconfig.json

@@ -9,13 +9,17 @@
     "dist-ssr"
   ],
   "compilerOptions": {
-    "baseUrl": ".",
+    // `baseUrl` YOK ve olmamalı: TypeScript 5'ten beri `paths` ona bağlı
+    // değil, değerler tsconfig'in bulunduğu dizine göre çözülüyor. TS 6'da
+    // `baseUrl` doğrudan hata veriyordu ve `tsc --noEmit` hiç koşmuyordu —
+    // yani tür kontrolünün tamamı kapalıydı. Aynı satır TS 7 geçişinin de
+    // engeliydi.
     "paths": {
       "#runtime-env": [
-        "src/data/runtimeEnv.ts"
+        "./src/data/runtimeEnv.ts"
       ],
       "#news-source": [
-        "src/data/newsSource.ts"
+        "./src/data/newsSource.ts"
       ]
     }
   }