Repository navigation
Commit 3dd4468
committed
Retire the dark patches that were hiding a token
Twenty-two of the fifty-nine dark-theme overrides were not carrying a decision.
Nine repeated what the base rule already said in tokens. Others hard-coded a
value a role already had a name for: #222b49 is --surface-soft, #151b28 is
--surface, #3f4960 is --line-hover.
A new --surface-sunken role covers the recessed fills — media frames, moderation
inputs, the remove button — where light says --paper but dark wants something a
shade above it. Where the two themes genuinely differ in shape rather than in
role, the value moves into light-dark() on the base declaration, so the pair now
sits on one line instead of two files apart. That gap is exactly how the last
contrast bug survived.
Verified with the colour snapshot: eight pages, both themes, thirteen changes,
all of them border-colour on sides whose width is 0 — measured in the browser,
not assumed. Nothing visible moved.
What stays is deliberate: the seven-component panel group that flattens
elevation in dark, the header and footer gradients, the accent hover states.
The five near-white light surfaces underneath the panel group want unifying,
but that belongs to the elevation decision in the typography pass, not here.1 parent 7bf8193 commit 3dd4468
4 files changed
Lines changed: 29 additions & 71 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
376 | | - | |
| 376 | + | |
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
| |||
559 | 559 | | |
560 | 560 | | |
561 | 561 | | |
562 | | - | |
| 562 | + | |
563 | 563 | | |
564 | 564 | | |
565 | 565 | | |
| |||
591 | 591 | | |
592 | 592 | | |
593 | 593 | | |
594 | | - | |
| 594 | + | |
595 | 595 | | |
596 | 596 | | |
597 | | - | |
| 597 | + | |
598 | 598 | | |
599 | 599 | | |
600 | 600 | | |
| |||
637 | 637 | | |
638 | 638 | | |
639 | 639 | | |
640 | | - | |
| 640 | + | |
641 | 641 | | |
642 | | - | |
| 642 | + | |
643 | 643 | | |
644 | 644 | | |
645 | 645 | | |
| |||
677 | 677 | | |
678 | 678 | | |
679 | 679 | | |
680 | | - | |
| 680 | + | |
681 | 681 | | |
682 | 682 | | |
683 | 683 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
963 | 963 | | |
964 | 964 | | |
965 | 965 | | |
966 | | - | |
| 966 | + | |
967 | 967 | | |
968 | 968 | | |
969 | 969 | | |
| |||
975 | 975 | | |
976 | 976 | | |
977 | 977 | | |
978 | | - | |
979 | | - | |
| 978 | + | |
| 979 | + | |
980 | 980 | | |
981 | 981 | | |
982 | 982 | | |
| |||
2126 | 2126 | | |
2127 | 2127 | | |
2128 | 2128 | | |
2129 | | - | |
| 2129 | + | |
2130 | 2130 | | |
2131 | 2131 | | |
2132 | 2132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| 46 | + | |
| 47 | + | |
45 | 48 | | |
46 | 49 | | |
47 | 50 | | |
48 | 51 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 52 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 53 | | |
58 | | - | |
59 | 54 | | |
60 | | - | |
61 | 55 | | |
62 | 56 | | |
63 | 57 | | |
64 | 58 | | |
65 | 59 | | |
66 | 60 | | |
67 | 61 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | 62 | | |
74 | 63 | | |
75 | | - | |
76 | | - | |
| 64 | + | |
| 65 | + | |
77 | 66 | | |
78 | 67 | | |
79 | 68 | | |
80 | 69 | | |
81 | | - | |
82 | | - | |
| 70 | + | |
| 71 | + | |
83 | 72 | | |
84 | 73 | | |
85 | 74 | | |
86 | 75 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | 76 | | |
93 | 77 | | |
94 | 78 | | |
| |||
110 | 94 | | |
111 | 95 | | |
112 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
113 | 102 | | |
114 | 103 | | |
115 | 104 | | |
| |||
137 | 126 | | |
138 | 127 | | |
139 | 128 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | 129 | | |
153 | 130 | | |
154 | 131 | | |
155 | | - | |
| 132 | + | |
156 | 133 | | |
157 | 134 | | |
158 | 135 | | |
159 | 136 | | |
160 | 137 | | |
161 | 138 | | |
162 | 139 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | 140 | | |
170 | 141 | | |
171 | 142 | | |
172 | 143 | | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | 144 | | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
| 145 | + | |
189 | 146 | | |
190 | 147 | | |
191 | 148 | | |
192 | | - | |
193 | | - | |
| 149 | + | |
| 150 | + | |
194 | 151 | | |
195 | 152 | | |
196 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
0 commit comments