Skip to content

Commit 70e7ce9

Browse files
sametbasbugclaude
andcommitted
Delete a constant that looked like a gate and was not one
REQUIRED_SECRET_BINDINGS was born in the first identity commit and never read by anything. Deleting it is not a dead-code cleanup; it is removing a false guarantee. Its name promised that a secret listed there was enforced, and that promise had already reached the ledger — "not in that list, on purpose" — while listing or omitting a secret changed nothing at all. It had also rotted, which is what an unread list does: ORBIT_CURSOR_PEPPER_V1 is required at runtime and never appeared in it. A comment in its place says where the real list lives, so the next person adding a secret is pointed at bindings.ts instead of re-inventing a parallel one. The ledger sentence that trusted it is corrected rather than quietly edited, since the reasoning it recorded was wrong and worth showing as wrong. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent f1858dc commit 70e7ce9

2 files changed

Lines changed: 20 additions & 12 deletions

File tree

‎docs/V6_PROJECT_LEDGER.md‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2137,10 +2137,14 @@ Anything under `docs/archive/` describes an earlier state and is frozen. Read it
21372137
- `ORBIT_OIDC_SIGNING_KEY_V1` and `ORBIT_SITE_TOKEN_PEPPER_V1` are staging
21382138
secrets now, and both are also in the `staging.orbit.sametbasbug` Keychain
21392139
service, which is where the rehearsal scripts read local secrets from. They
2140-
are still NOT in `REQUIRED_SECRET_BINDINGS` or the production config check,
2141-
on purpose: making a binding required takes down every deployed version that
2142-
lacks it, and production has neither secret yet. That step belongs to the
2143-
production rollout, after production has them.
2140+
are deliberately not required bindings while production lacks them: making a
2141+
binding required takes down every deployed version without it. That step
2142+
belongs to the production rollout, after production has them.
2143+
(Correction, 12 August: the original wording here credited
2144+
`REQUIRED_SECRET_BINDINGS` with that safety property. That constant was
2145+
referenced nowhere — it gated nothing, and it had already drifted out of step
2146+
with the runtime list. It is deleted; `assertIdentityBindings` in
2147+
`bindings.ts` is the only list that decides anything.)
21442148
- Equinox Rota is registered in staging D1 as client `orbit-equinox-rota`, one
21452149
redirect URI, scopes `openid profile email`. Narrow on purpose — the graph and
21462150
posts scopes can be added later, and widening asks the user again rather than

‎src/server/identity/constants.ts‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,15 @@ export const CSRF_HEADER = 'X-Orbit-CSRF';
104104

105105
export const TOKEN_HASH_VERSION = 1;
106106

107-
export const REQUIRED_SECRET_BINDINGS = [
108-
'GOOGLE_OAUTH_CLIENT_SECRET',
109-
'ORBIT_INVITATION_PEPPER_V1',
110-
'ORBIT_SESSION_PEPPER_V1',
111-
'ORBIT_AGENT_CREDENTIAL_PEPPER_V1',
112-
'ORBIT_OAUTH_STATE_PEPPER_V1',
113-
'ORBIT_CSRF_PEPPER_V1',
114-
] as const;
107+
/* Burada bir `REQUIRED_SECRET_BINDINGS` listesi vardı ve silindi.
108+
*
109+
* Hiçbir yerden kullanılmıyordu — ilk kimlik commit'inde doğdu, hiç okunmadı.
110+
* Zorunlu bağlamaların tek gerçek yeri `bindings.ts` içindeki
111+
* `assertIdentityBindings`; yeni bir sır eklerken bakılacak yer orası.
112+
*
113+
* Silinmesinin sebebi ölü kod olması değil, KAPI GİBİ GÖRÜNMESİYDİ. Adı bir
114+
* güvence vaat ediyordu ve o vaat kayda bile geçmişti ("şu sır bu listede
115+
* değil, bilerek") — oysa listeye girmek de girmemek de hiçbir şeyi
116+
* değiştiriyordu. Üstelik çürümüştü: `ORBIT_CURSOR_PEPPER_V1` çalışma
117+
* zamanında zorunluyken bu listede hiç yoktu. Kimsenin okumadığı bir liste
118+
* sessizce yanlışa kayar, ve yanlış olduğu gün ona güvenen biri çıkar. */

0 commit comments

Comments
 (0)