Repository navigation
Commit 7a5d47f
Ship the Google credential with the Worker version, not the GitHub one
The production deploy was still writing GITHUB_OAUTH_CLIENT_ID and
GITHUB_OAUTH_CLIENT_SECRET onto a Worker that no longer has a GitHub
provider, and refusing to deploy at all if either Actions secret was
absent. Two dead secrets refreshed on every deploy, and a hostage: deleting
the stale Actions secrets would have broken deploys.
The design is kept because the design is right — credentials ride with the
Worker version, so a version is self-contained and a deploy re-establishes
sign-in rather than depending on someone having run `wrangler secret put`
once. Only the destination changes: the same two Actions secrets now land
on GOOGLE_OAUTH_CLIENT_ID and GOOGLE_OAUTH_CLIENT_SECRET.
The config guard asserted that the deploy sources the pair from the
production environment, and it kept passing all day while the pair went to
the wrong bindings — because what went stale was the destination and the
guard only watched the source. It now asserts the binding names, and that
no GitHub OAuth binding is uploaded at all. Revert-checked: putting the
GitHub names back fails with the message that names the consequence.
DEPLOY ORDER MATTERS HERE. The two Actions secrets still hold the GitHub
client ID and secret. Pushing this before they are updated to the Google
values would overwrite the working GOOGLE_* secrets with GitHub ones and
break sign-in on the live site immediately. This commit is deliberately not
pushed.
Local proof: `npm run build` end to end, 81 config assertions.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent cdfe878 commit 7a5d47f
3 files changed
Lines changed: 31 additions & 3 deletions
File tree
- .github/workflows
- docs
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
| 259 | + | |
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
272 | | - | |
| 271 | + | |
| 272 | + | |
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2056 | 2056 | | |
2057 | 2057 | | |
2058 | 2058 | | |
| 2059 | + | |
| 2060 | + | |
| 2061 | + | |
| 2062 | + | |
| 2063 | + | |
| 2064 | + | |
| 2065 | + | |
| 2066 | + | |
| 2067 | + | |
| 2068 | + | |
| 2069 | + | |
| 2070 | + | |
| 2071 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
294 | 309 | | |
295 | 310 | | |
296 | 311 | | |
| |||
0 commit comments