Repository navigation
Avoid Diffsync character-code overflow from earlier searches - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode Diffsync character IDs relative to the start of each execution, preserving their existing order. This prevents earlier searches from exhausting the adapter's Unicode range.
Failing case: with the process-wide character counter at
0x110000, seed 1 with two clients and one operation incorrectly reports convergence and list-specification failures. It now passes. This is a long-running test-process issue; there is no evidence it affected the paper's results, and the existing Diffsync classification is unchanged. The encoding still has a per-search Unicode limit.Verified 300 matching traces before/after, including large starting IDs, plus exhaustive BFS/DFS and all existing test modules. Ruff and Pyright pass. No new test files or paper changes.