Add Integration Test for Validator Modes - #3968
Open
knoppiks wants to merge 1 commit into
Open
Conversation
knoppiks
force-pushed
the
3847-add-synthea-integration-test-for-external-validator-failure-modes
branch
from
July 29, 2026 10:19
8b24dca to
21cb72c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3968 +/- ##
==========================================
- Coverage 96.45% 96.44% -0.01%
==========================================
Files 437 437
Lines 27425 27425
Branches 627 630 +3
==========================================
- Hits 26453 26451 -2
- Misses 469 470 +1
- Partials 503 504 +1 🚀 New features to boost your workflow:
|
knoppiks
force-pushed
the
3847-add-synthea-integration-test-for-external-validator-failure-modes
branch
from
July 29, 2026 15:02
21cb72c to
c327d55
Compare
Collaborator
Author
knoppiks
force-pushed
the
3847-add-synthea-integration-test-for-external-validator-failure-modes
branch
2 times, most recently
from
July 31, 2026 20:53
349fd88 to
36d3806
Compare
knoppiks
marked this pull request as ready for review
July 31, 2026 20:57
knoppiks
force-pushed
the
3847-add-synthea-integration-test-for-external-validator-failure-modes
branch
from
August 1, 2026 20:58
36d3806 to
5f57613
Compare
alexanderkiel
requested changes
Aug 4, 2026
alexanderkiel
left a comment
alexanderkiel
left a comment
Member
There was a problem hiding this comment.
Please load USCore into the terminology server and active SNOMED CT.
| @@ -53,6 +53,17 @@ services: | |||
| - "8084:8080" | |||
| volumes: | |||
| - ./fhir-settings.json:/app/fhir-settings.json:ro | |||
Member
There was a problem hiding this comment.
Not needed anymore, because the mii-fhir-validator generated the fhir-settings.json at startup. Please remove this volume mount and the file.
| # --- no invalid resource was persisted -------------------------------------- | ||
|
|
||
| test "number of persisted invalid Patients" \ | ||
| "$(curl -s -H 'Accept: application/fhir+json' "$base/Patient?_tag=${tag_system}|invalid&_summary=count" | jq -r '.total')" "0" |
Member
There was a problem hiding this comment.
Please use search_strict here
|
|
||
| # Creates a subset of the Synthea test data in the `synthea-subset` directory. | ||
| # Validating every resource of the full Synthea data set against the external | ||
| # validator would be too slow, so only three of the 121 patient bundles are |
Member
There was a problem hiding this comment.
this are not three patient bundles, instead you have two master data bundles and one patient bundle
Closes: #3847 Signed-off-by: Jonas Wagner <jwagner@knoppiks.de>
knoppiks
force-pushed
the
3847-add-synthea-integration-test-for-external-validator-failure-modes
branch
from
August 4, 2026 12:39
5f57613 to
d9c6544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.