test: tighten initializer dependency pinning and coverage

Author: Copilot

playwright-ct-angular/create-playwright-sand4rt/index.js

@@ -3,11 +3,11 @@
 const path = require('path');
 const { spawnSync } = require('child_process');
 const {
-  CT_PACKAGE_NAME,
   hasCtFlag,
   targetDirFromArgs,
   detectPackageManager,
   patchPackageJson,
+  installArgsForPackageManager,
 } = require('./lib');
 
 const args = process.argv.slice(2);
@@ -19,7 +19,7 @@ const createPlaywrightResult = spawnSync(
 );
 
 if (createPlaywrightResult.status !== 0)
-  process.exit(createPlaywrightResult.status || 1);
+  process.exit(createPlaywrightResult.status ?? 1);
 
 if (!hasCtFlag(args))
   process.exit(0);
@@ -29,16 +29,12 @@ if (!patchPackageJson(targetDir))
   process.exit(0);
 
 const packageManager = detectPackageManager(targetDir);
-const installArgs = packageManager === 'pnpm'
-  ? ['add', '--save-dev', CT_PACKAGE_NAME]
-  : packageManager === 'yarn'
-    ? ['add', '--dev', CT_PACKAGE_NAME]
-    : ['install', '--save-dev', CT_PACKAGE_NAME];
+const installArgs = installArgsForPackageManager(packageManager);
 
 const installResult = spawnSync(packageManager, installArgs, {
   cwd: targetDir,
   stdio: 'inherit',
 });
 
 if (installResult.status !== 0)
-  process.exit(installResult.status || 1);
+  process.exit(installResult.status ?? 1);

playwright-ct-angular/create-playwright-sand4rt/lib.js

@@ -1,7 +1,10 @@
 const fs = require('fs');
 const path = require('path');
+const packageJson = require('./package.json');
 
 const CT_PACKAGE_NAME = '@sand4rt/experimental-ct-angular';
+const CT_PACKAGE_VERSION = packageJson.config.ctPackageVersion;
+const CT_PACKAGE_SPEC = `${CT_PACKAGE_NAME}@${CT_PACKAGE_VERSION}`;
 
 function hasCtFlag(args) {
   return args.includes('--ct');
@@ -46,16 +49,27 @@ function patchPackageJson(projectDir) {
   const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
   packageJson.devDependencies ??= {};
   delete packageJson.devDependencies.undefined;
-  packageJson.devDependencies[CT_PACKAGE_NAME] = 'latest';
+  packageJson.devDependencies[CT_PACKAGE_NAME] = CT_PACKAGE_VERSION;
 
   fs.writeFileSync(packageJsonPath, `${JSON.stringify(packageJson, null, 2)}\n`);
   return true;
 }
 
+function installArgsForPackageManager(packageManager) {
+  if (packageManager === 'pnpm')
+    return ['add', '--save-dev', '--save-exact', CT_PACKAGE_SPEC];
+  if (packageManager === 'yarn')
+    return ['add', '--dev', '--exact', CT_PACKAGE_SPEC];
+  return ['install', '--save-dev', '--save-exact', CT_PACKAGE_SPEC];
+}
+
 module.exports = {
   CT_PACKAGE_NAME,
+  CT_PACKAGE_VERSION,
+  CT_PACKAGE_SPEC,
   hasCtFlag,
   targetDirFromArgs,
   detectPackageManager,
   patchPackageJson,
+  installArgsForPackageManager,
 };

playwright-ct-angular/create-playwright-sand4rt/package.json

@@ -8,5 +8,8 @@
   "scripts": {
     "test": "node --test"
   },
+  "config": {
+    "ctPackageVersion": "1.58.2"
+  },
   "license": "MIT"
 }

playwright-ct-angular/create-playwright-sand4rt/test/lib.test.js

@@ -5,10 +5,14 @@ const os = require('os');
 const path = require('path');
 
 const {
+  CT_PACKAGE_NAME,
+  CT_PACKAGE_VERSION,
+  CT_PACKAGE_SPEC,
   hasCtFlag,
   targetDirFromArgs,
   detectPackageManager,
   patchPackageJson,
+  installArgsForPackageManager,
 } = require('../lib');
 
 test('hasCtFlag detects ct mode', () => {
@@ -53,7 +57,13 @@ test('patchPackageJson replaces undefined dependency with ct angular package', (
   const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
   assert.equal(packageJson.devDependencies.undefined, undefined);
   assert.equal(packageJson.devDependencies['@types/node'], '^20.0.0');
-  assert.equal(packageJson.devDependencies['@sand4rt/experimental-ct-angular'], 'latest');
+  assert.equal(packageJson.devDependencies[CT_PACKAGE_NAME], CT_PACKAGE_VERSION);
 
   fs.rmSync(tempDir, { recursive: true, force: true });
 });
+
+test('installArgsForPackageManager enforces exact dependency installs', () => {
+  assert.deepEqual(installArgsForPackageManager('npm'), ['install', '--save-dev', '--save-exact', CT_PACKAGE_SPEC]);
+  assert.deepEqual(installArgsForPackageManager('pnpm'), ['add', '--save-dev', '--save-exact', CT_PACKAGE_SPEC]);
+  assert.deepEqual(installArgsForPackageManager('yarn'), ['add', '--dev', '--exact', CT_PACKAGE_SPEC]);
+});