This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: centralize edge type metadata into EdgeTypeRegistry - #115
Merged
sauravbhattacharya001 merged 1 commit intoMar 28, 2026
Merged
Conversation
Extract duplicated edge type names, hex colors, and RGB colors from DotExporter and GexfExporter into a single EdgeTypeRegistry utility class. Before: each exporter maintained its own copy of the type-to-name and type-to-color mappings. Adding a new edge type required updating 5+ files. After: single source of truth in EdgeTypeRegistry. Exporters delegate to it via static methods (getName, getHexColor, getRgbColor). Refactored: - DotExporter: removed DEFAULT_TYPE_COLORS static block and getTypeName() switch statement, now uses EdgeTypeRegistry - GexfExporter: removed TYPE_COLORS static block, now uses EdgeTypeRegistry.getRgbColor()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts duplicated edge type metadata (names, hex colors, RGB colors) from individual exporters into a new \EdgeTypeRegistry\ utility class.
Why
Before this change, edge type → name/color mappings were copy-pasted across DotExporter, GexfExporter, GraphTimelineExporter, InteractiveHtmlExporter, and CsvReportExporter. Adding a new edge type required updating 5+ files — easy to miss one and end up with inconsistent colors or names.
Changes
Future
The remaining exporters (GraphTimelineExporter, InteractiveHtmlExporter) embed type metadata in inline JavaScript strings, which makes Java-side refactoring less clean. Those can be addressed in a follow-up.