This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: add equals/hashCode/toString to Edge class - #116
Merged
sauravbhattacharya001 merged 1 commit intoMar 28, 2026
Merged
Conversation
The Edge class is used extensively in Sets and Maps throughout the codebase (e.g., ShortestPathFinder, CommunityDetector, GraphStats) but was relying on Object's identity-based equals/hashCode. This meant two Edge objects connecting the same vertices with the same type and weight were not considered equal in collections. - equals: order-independent vertex comparison (undirected edges) - hashCode: consistent with equals, order-independent - toString: readable format for debugging: Edge[v1--v2, type=f, weight=1.0]
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The \Edge\ class is used in Sets and Maps throughout the codebase but was relying on \Object's identity-based \�quals/\hashCode. This meant two Edge objects connecting the same vertices with the same type and weight were not considered equal in collections.
Changes
Why
Multiple analyzers (ShortestPathFinder, CommunityDetector, GraphDiffAnalyzer, etc.) store Edge objects in Sets and Maps. Without proper equals/hashCode, duplicate detection and lookups behave incorrectly in subtle ways.