This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: extract MeetingQueryConfig to eliminate 13-param method and 5 duplicate SQL strings - #119
Closed
sauravbhattacharya001 wants to merge 1 commit into
Closed
sauravbhattacharya001 wants to merge 1 commit into
sauravbhattacharya001 wants to merge 1 commit into
Conversation
… 5 duplicate SQL strings Network.generateFile() had 13 parameters and 5 near-identical SQL query strings that only differed in location filter and comparison operators. Changes: - New MeetingQueryConfig class encapsulates per-relationship-type query differences (location filter mode, comparison direction, thresholds) - MeetingQueryConfig.buildSql() generates the parameterised SQL from config - New generateFile(path, month, date, List<MeetingQueryConfig>) overload - Original 13-param method preserved as @deprecated for backward compat - Zero behavior change: deprecated method delegates to new one
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Closing: superseded or conflicting with newer changes already on main/master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Network.generateFile() had 13 parameters and 5 near-identical SQL query strings.
Solution