This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: replace double[] PQ hack in GraphUtils.dijkstra with typed DijkstraEntry - #126
Merged
sauravbhattacharya001 merged 1 commit intoMar 28, 2026
Conversation
…DijkstraEntry The previous implementation used double[] arrays as PQ entries with a parallel vertexIndex list and vertexToIdx map for int-to-vertex lookups. This required fragile double-to-int casting on every PQ poll and O(V) index bookkeeping. Replaced with a typed DijkstraEntry class (distance + vertex String), matching the pattern already used in ShortestPathFinder. This eliminates the vertexIndex list, vertexToIdx map, and the casting, making the code clearer and less error-prone.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces double[] PQ entries with a typed DijkstraEntry class, eliminating the vertexIndex/vertexToIdx indirection. Consistent with ShortestPathFinder's approach. No behavioral change.