This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: deduplicate escapeXml across 5 layout/animator classes - #128
Merged
Merged
Conversation
Five classes had private escapeXml() methods with copy-pasted XML escaping logic. Replaced each with a one-line delegation to the canonical ExportUtils.escapeXml(), which already handles null safety and all five XML special characters. Affected: CircularLayout, ForceDirectedLayout, GraphAlgorithmAnimator, HierarchicalLayout, SpectralLayout. GexfExporter and SvgExporter already delegated correctly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five classes had private \�scapeXml()\ methods with copy-pasted XML escaping logic. \ExportUtils.escapeXml()\ already provides a canonical, null-safe implementation.
Changes
Replaced inline implementations in CircularLayout, ForceDirectedLayout, GraphAlgorithmAnimator, HierarchicalLayout, and SpectralLayout with one-line delegations to \ExportUtils.escapeXml().
GexfExporter and SvgExporter already delegated correctly — no changes needed.
Impact