This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: eliminate 20 redundant field aliases in Main.java - #130
Merged
sauravbhattacharya001 merged 1 commit intoMar 28, 2026
Merged
Conversation
The initializeCategoryPanel() method created CategoryRow[] but then aliased every component back to 20+ individual instance fields (showFriend, friendDurThreshold, frShowParam, frHpanel, etc.). These fields were only consumed by currentThresholds() and isEdgeTypeVisible(), which now read directly from categoryRows[]. Also converted 7 timeline button fields to local variables since they were only used within initializeTimeLine(). Net reduction: 63 lines of dead field declarations and aliasing code.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 20+ redundant instance field declarations and their aliasing assignments from \Main.java.
Problem
\initializeCategoryPanel()\ created a well-structured \CategoryRow[]\ array but then immediately aliased every component back to individual fields (\showFriend, \ riendDurThreshold, \ rShowParam, \ rHpanel, etc. × 5 categories = 25 aliases).
These fields were only consumed by \currentThresholds()\ and \isEdgeTypeVisible(), creating unnecessary indirection.
Changes
Net: -63 lines, zero behavioral change.