This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor(app): extract LocationResolver from addLocation - #131
Merged
Merged
Conversation
- Rename addLocation → LocationResolver (Java naming conventions) - Extract magic AP numbers from switch into a static Map (AP_LOCATION_MAP) with a classifyAP() method for testability - Extract duplicated single-IMEI AP query logic into findBestAP() helper - Fix ResultSet iteration (use rs.next() once, not while loop for LIMIT 1) The original addLocation.java is preserved for backward compatibility.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Refactors the ^GddLocation\ class into a cleaner \LocationResolver: ### 1. Java naming conventions Class renamed from ^GddLocation\ to \LocationResolver\ (PascalCase). ### 2. Magic numbers → configurable Map The AP-to-location-type switch statement with hard-coded AP IDs (7, 16, 20, etc.) is replaced with a static \AP_LOCATION_MAP\ and a \classifyAP()\ method. This is: - Easier to read and maintain - Unit-testable in isolation - Extensible without modifying control flow ### 3. Duplicated query logic → helper method The identical single-IMEI AP lookup code that was copy-pasted 2x is now a \ indBestAP()\ helper method. ### 4. ResultSet fix Changed \while (rs.next())\ to \if (rs.next())\ for LIMIT 1 queries — the loop was semantically misleading since only one row is ever returned. Original ^GddLocation.java\ is preserved for backward compatibility.