This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: deduplicate edge type name/color mappings via EdgeTypeRegistry - #132
Merged
sauravbhattacharya001 merged 1 commit intoMar 30, 2026
Merged
Conversation
Replace hardcoded edge type name and color switch statements in AdjacencyMatrixHeatmap, InteractiveHtmlExporter, SvgExporter, and NetworkReportGenerator with calls to the existing EdgeTypeRegistry. This eliminates 5 copies of the type-to-name mapping and 3 copies of the type-to-color mapping. Adding a new edge type now requires updating only EdgeTypeRegistry instead of 5+ files.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hardcoded edge type name and color switch statements in 4 files with calls to the existing \EdgeTypeRegistry.
Files changed
Why
Adding a new edge type previously required updating 5+ files. Now only \EdgeTypeRegistry\ needs to change.
-41 lines, +18 lines — net reduction of 23 lines of duplicated mappings.