This repository was archived by the owner on Jun 18, 2026. It is now read-only.
fix: broaden friend edge detection to all resolved non-class locations - #137
Merged
Merged
Conversation
The friend SQL query was hardcoded to location='public', missing meetings
at cafes, libraries, paths, and other resolved locations. This caused
under-counting of friend edges compared to stranger/familiar-stranger
queries which already used location NOT IN ('class','unknown','').
Align the friend query with the same inclusive filter used by the other
relationship types.
Fixes #134
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The friend SQL query in Network.java was hardcoded to location = 'public', missing meetings at cafes, libraries, paths, and other resolved locations. This caused under-counting of friend edges.
Changes
Fixes #134