This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: extract buildMeetingQuery() to eliminate duplicated SQL templates - #138
Closed
sauravbhattacharya001 wants to merge 1 commit into
Closed
sauravbhattacharya001 wants to merge 1 commit into
sauravbhattacharya001 wants to merge 1 commit into
Conversation
…emplates Network.java had 5 nearly identical SQL query strings that differed only in location filter, duration operator, and count operator. Extracted a shared buildMeetingQuery(locationFilter, durationOp, countOp) method that generates the parameterized SQL, reducing ~40 lines of duplicated query definitions to 5 clean one-liner calls. No behavioral change — queries produce identical SQL.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Closing — changes already landed via direct push or superseded. No longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extracted a shared \�uildMeetingQuery(locationFilter, durationOp, countOp)\ method in \Network.java\ that generates parameterized SQL queries for all 5 relationship types (friends, study groups, classmates, strangers, familiar strangers).
Before: 5 separate multi-line SQL string constants (~40 lines) with nearly identical structure, differing only in location filter, duration comparison, and count comparison.
After: One reusable method + 5 clean one-liner calls. Reduces duplication and makes it trivial to add new relationship types or modify the query structure.
No behavioral change — generates identical SQL.