This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: extract shared DirectedAdj and safeNeighbors into GraphUtils - #75
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Move DirectedAdj class and buildDirectedAdjacencyMap from TopologicalSortAnalyzer to GraphUtils for reuse by other analyzers - Add GraphUtils.neighborsOf() null-safe neighbor access helper - Update CycleAnalyzer, GraphColoringAnalyzer, GraphEntropyAnalyzer to use shared neighborsOf() instead of inline null checks - Remove ~67 lines of duplicated code across 4 analyzers Closes #43
sauravbhattacharya001
force-pushed
the
refactor/consolidate-adjacency-bfs
branch
from
March 14, 2026 11:34
4db289a to
0ab3e33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #43. Adds shared \DirectedAdj, \�uildDirectedAdjacencyMap(), and \safeNeighbors()\ to GraphUtils. Refactors TopologicalSortAnalyzer and CycleAnalyzer to use them. All relevant tests pass.