This repository was archived by the owner on Jun 18, 2026. It is now read-only.
fix: remove 20 unused imports + deduplicate BFS in 2 analyzers - #76
Merged
Merged
Conversation
Two improvements:
1. Code cleanup — removed 20 unused imports across 18 files:
- 8 files had unused UndirectedSparseGraph/DirectedSparseGraph/
UndirectedGraph imports from edu.uci.ics.jung.graph
- 10 files had unused java.util.stream.Collectors imports
2. Refactor — eliminated duplicate BFS implementations:
- GraphNetworkProfiler: removed 19-line private bfs() method,
replaced 3 call sites with GraphUtils.bfsDistances()
- ForceDirectedLayout: removed 10-line private bfsDistances()
method, replaced 1 call site with GraphUtils.bfsDistances()
- GraphUtils.bfsDistances() already provides the same
functionality; these were unnecessary copies
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleanup: 20 unused imports removed (18 files)
UndirectedSparseGraphUndirectedGraphUndirectedSparseGraphCollectorsCollectorsCollectorsCollectorsUndirectedSparseGraphCollectorsCollectorsUndirectedSparseGraph,CollectorsUndirectedSparseGraphUndirectedSparseGraphCollectorsCollectorsDirectedSparseGraph,CollectorsUndirectedSparseGraphUndirectedSparseGraphRefactor: deduplicate BFS implementations
GraphNetworkProfiler — removed 19-line private
bfs()method, replaced 3 call sites withGraphUtils.bfsDistances(graph, ...). The private method was functionally identical to the shared utility.ForceDirectedLayout — removed 10-line private
bfsDistances()method, replaced 1 call site withGraphUtils.bfsDistances(graph, ...). Same deduplication.Both methods produced the same
Map<String, Integer>(vertex → BFS distance) asGraphUtils.bfsDistances(). Consolidated to reduce code duplication and maintenance burden.