This repository was archived by the owner on Jun 18, 2026. It is now read-only.
refactor: extract duplicate BFS in NetworkFlowAnalyzer - #79
Merged
sauravbhattacharya001 merged 1 commit intoMar 15, 2026
Merged
Conversation
…ant computation The getMinCut() and getSourceSide() methods both contained identical BFS traversals to find vertices reachable from source in the residual graph. Extracted into a single findReachableFromSource() private method. Also fixed getSummary() and getResult() which were calling decomposeFlowPaths(), getMinCut(), and getBottleneckEdges() independently — each triggering their own traversals. Now each method computes these expensive results once and reuses them. Changes: - New private findReachableFromSource() method (single BFS) - getMinCut() delegates to findReachableFromSource() - getSourceSide() delegates to findReachableFromSource() - getSummary() computes paths/minCut/bottlenecks once, reuses - getResult() computes paths/minCut/bottlenecks once, reuses No behavioral changes — all 52 existing tests remain valid.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
sauravbhattacharya001
deleted the
gardener/refactor-network-flow-analyzer
branch
March 15, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
\getMinCut()\ and \getSourceSide()\ both contained identical 15-line BFS traversals to find vertices reachable from source in the residual graph. Additionally, \getSummary()\ and \getResult()\ called \decomposeFlowPaths(), \getMinCut(), and \getBottleneckEdges()\ independently — each triggering separate graph traversals.
Changes:
Impact: No behavioral changes. All 52 existing tests remain valid. Reduces code duplication and avoids redundant O(V+E) traversals.