This repository was archived by the owner on Jun 18, 2026. It is now read-only.
test: add comprehensive tests for GraphFileParser - #93
Merged
Merged
Conversation
22 test cases covering: - Basic node/edge parsing and edge type classification - Edge weight preservation and validation (NaN, Infinity, invalid) - Malformed edge lines gracefully skipped with count - Empty files and nodes-only files - Blank line and whitespace tolerance - Case-insensitive section headers - Filter predicate (include/exclude edge types from graph) - Unknown edge type codes handled correctly - First-edge-of-type label assignment for legends - Zero and negative weights accepted - I/O error propagation for missing files - getEdges() returns empty list for unused types
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 22 JUnit test cases for \GraphFileParser, which previously had zero test coverage despite being the core file I/O and parsing logic.
Test Coverage
Why This Matters
\GraphFileParser.parse()\ is used by every analysis pipeline and the main UI. A parsing regression (e.g. silently dropping edges or misclassifying types) would propagate to all downstream analysis results.