Skip to content
This repository was archived by the owner on Aug 19, 2026. It is now read-only.

Commit 49820cc

Browse files
sbryngelsonsbryngelson
committed
remove dead code: weno_Re_flux, null_weights, GRCBC fields, unused MPI routines
- Remove weno_Re_flux, null_weights from simulation global parameters, defaults, and MPI broadcasts (declared but never read) - Remove pres_in/pres_out, vel_in/vel_out, grcbc_in/grcbc_out/grcbc_vel_out from int_bounds_info type (broadcast and GPU-updated but never read) - Remove s_mpi_allreduce_vectors_sum, s_mpi_allreduce_integer_sum from m_mpi_common (public, zero callers) - Remove dead rdma_mpi PROHIBIT check from m_checker
1 parent 9357c50 commit 49820cc

6 files changed

Lines changed: 1 addition & 64 deletions

File tree

‎src/common/m_derived_types.fpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,7 @@ module m_derived_types
5454
real(wp) :: ve1
5555
real(wp) :: ve2
5656
real(wp) :: ve3
57-
real(wp) :: pres_in, pres_out
58-
real(wp), dimension(3) :: vel_in, vel_out
5957
real(wp), dimension(num_fluids_max) :: alpha_rho_in, alpha_in
60-
logical :: grcbc_in, grcbc_out, grcbc_vel_out
6158
end type int_bounds_info
6259

6360
type bc_patch_parameters

‎src/common/m_mpi_common.fpp‎

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -265,35 +265,6 @@ contains
265265

266266
end subroutine s_mpi_allreduce_sum
267267

268-
!> Reduce an array of vectors to their global sums across all MPI ranks.
269-
impure subroutine s_mpi_allreduce_vectors_sum(var_loc, var_glb, num_vectors, vector_length)
270-
271-
integer, intent(in) :: num_vectors, vector_length
272-
real(wp), dimension(:,:), intent(in) :: var_loc
273-
real(wp), dimension(:,:), intent(out) :: var_glb
274-
275-
integer :: ierr !< Generic flag used to identify and report MPI errors
276-
277-
if (loc(var_loc) == loc(var_glb)) then
278-
call MPI_Allreduce(MPI_IN_PLACE, var_glb, num_vectors*vector_length, mpi_p, MPI_SUM, MPI_COMM_WORLD, ierr)
279-
else
280-
call MPI_Allreduce(var_loc, var_glb, num_vectors*vector_length, mpi_p, MPI_SUM, MPI_COMM_WORLD, ierr)
281-
end if
282-
283-
end subroutine s_mpi_allreduce_vectors_sum
284-
285-
!> Reduce a local integer value to its global sum across all MPI ranks.
286-
impure subroutine s_mpi_allreduce_integer_sum(var_loc, var_glb)
287-
288-
integer, intent(in) :: var_loc
289-
integer, intent(out) :: var_glb
290-
291-
integer :: ierr !< Generic flag used to identify and report MPI errors
292-
293-
call MPI_ALLREDUCE(var_loc, var_glb, 1, MPI_INTEGER, MPI_SUM, MPI_COMM_WORLD, ierr)
294-
295-
end subroutine s_mpi_allreduce_integer_sum
296-
297268
!> Reduce a local real value to its global minimum across all MPI ranks.
298269
impure subroutine s_mpi_allreduce_min(var_loc, var_glb)
299270

‎src/simulation/m_checker.fpp‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ contains
3131
!> Checks constraints on compiler options
3232
impure subroutine s_check_inputs_compilers
3333

34-
#if !defined(MFC_OpenACC) && !(defined(__PGI) || defined(_CRAYFTN))
35-
@:PROHIBIT(rdma_mpi, "Unsupported value of rdma_mpi for the current compiler")
36-
#endif
37-
3834
end subroutine s_check_inputs_compilers
3935

4036
!> Checks constraints on time stepping parameters

‎src/simulation/m_global_parameters.fpp‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ module m_global_parameters
143143
real(wp) :: teno_CT !< Smoothness threshold for TENO
144144
logical :: mp_weno !< Monotonicity preserving (MP) WENO
145145
logical :: weno_avg !< Average left/right cell-boundary states
146-
logical :: weno_Re_flux !< WENO reconstruct velocity gradients for viscous stress tensor
147-
logical :: null_weights !< Null undesired WENO weights
148146
logical :: mixture_err !< Mixture properties correction
149147
logical :: shear_stress !< Shear stresses (computed from Re)
150148
logical :: bulk_stress !< Bulk stresses (computed from Re)
@@ -320,8 +318,6 @@ contains
320318
teno_CT = dflt_real
321319
mp_weno = .false.
322320
weno_avg = .false.
323-
weno_Re_flux = .false.
324-
null_weights = .false.
325321
mixture_err = .false.
326322
parallel_io = .false.
327323
file_per_process = .false.
@@ -387,13 +383,6 @@ contains
387383

388384
dummy = .false.
389385

390-
! GRCBC flags
391-
#:for dir in {'x', 'y', 'z'}
392-
bc_${dir}$%grcbc_in = .false.
393-
bc_${dir}$%grcbc_out = .false.
394-
bc_${dir}$%grcbc_vel_out = .false.
395-
#:endfor
396-
397386
end subroutine s_assign_default_values_to_user_inputs
398387

399388
!> Initialize the global parameters module

‎src/simulation/m_mpi_proxy.fpp‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,8 @@ contains
5454

5555
#:for VAR in [ 'run_time_info', &
5656
& 'mp_weno', 'rdma_mpi', 'bc_io', &
57-
& 'weno_Re_flux', 'null_weights', 'mixture_err', &
58-
& 'parallel_io', &
57+
& 'mixture_err', 'parallel_io', &
5958
& 'prim_vars_wrt', 'weno_avg', 'file_per_process', &
60-
& 'bc_x%grcbc_in', 'bc_x%grcbc_out', 'bc_x%grcbc_vel_out', &
61-
& 'bc_y%grcbc_in', 'bc_y%grcbc_out', 'bc_y%grcbc_vel_out', &
62-
& 'bc_z%grcbc_in', 'bc_z%grcbc_out', 'bc_z%grcbc_vel_out', &
6359
& 'cfl_adap_dt', 'cfl_const_dt', 'cfl_dt', &
6460
& 'down_sample']
6561
call MPI_BCAST(${VAR}$, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
@@ -69,20 +65,12 @@ contains
6965
& 'bc_x%vb1','bc_x%vb2','bc_x%vb3','bc_x%ve1','bc_x%ve2','bc_x%ve3', &
7066
& 'bc_y%vb1','bc_y%vb2','bc_y%vb3','bc_y%ve1','bc_y%ve2','bc_y%ve3', &
7167
& 'bc_z%vb1','bc_z%vb2','bc_z%vb3','bc_z%ve1','bc_z%ve2','bc_z%ve3', &
72-
& 'bc_x%pres_in','bc_x%pres_out','bc_y%pres_in','bc_y%pres_out', 'bc_z%pres_in','bc_z%pres_out', &
7368
& 'x_domain%beg', 'x_domain%end', 'y_domain%beg', 'y_domain%end', &
7469
& 'z_domain%beg', 'z_domain%end', 'x_a', 'x_b', 'y_a', 'y_b', 'z_a', &
7570
& 'z_b', 't_stop', 't_save', 'cfl_target', 'alf_factor' ]
7671
call MPI_BCAST(${VAR}$, 1, mpi_p, 0, MPI_COMM_WORLD, ierr)
7772
#:endfor
7873

79-
do i = 1, 3
80-
#:for VAR in [ 'bc_x%vel_in', 'bc_x%vel_out', 'bc_y%vel_in', 'bc_y%vel_out', &
81-
& 'bc_z%vel_in', 'bc_z%vel_out']
82-
call MPI_BCAST(${VAR}$ (i), 1, mpi_p, 0, MPI_COMM_WORLD, ierr)
83-
#:endfor
84-
end do
85-
8674
#:if not MFC_CASE_OPTIMIZATION
8775
call MPI_BCAST(mapped_weno, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
8876
call MPI_BCAST(wenoz, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)

‎src/simulation/m_start_up.fpp‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -743,10 +743,6 @@ contains
743743
$:GPU_UPDATE(device='[bc_y%vb1, bc_y%vb2, bc_y%vb3, bc_y%ve1, bc_y%ve2, bc_y%ve3]')
744744
$:GPU_UPDATE(device='[bc_z%vb1, bc_z%vb2, bc_z%vb3, bc_z%ve1, bc_z%ve2, bc_z%ve3]')
745745

746-
$:GPU_UPDATE(device='[bc_x%grcbc_in, bc_x%grcbc_out, bc_x%grcbc_vel_out]')
747-
$:GPU_UPDATE(device='[bc_y%grcbc_in, bc_y%grcbc_out, bc_y%grcbc_vel_out]')
748-
$:GPU_UPDATE(device='[bc_z%grcbc_in, bc_z%grcbc_out, bc_z%grcbc_vel_out]')
749-
750746
#:if not MFC_CASE_OPTIMIZATION
751747
$:GPU_UPDATE(device='[igr_order]')
752748
#:endif

0 commit comments

Comments
 (0)