Keep references to local capsets in inferred types - #26879
Open
bracevac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26000
#25976 preserved
^{C}by marking closure parameters@declaredin PostTyper, but only when the lambda is the direct RHS of a named definition.It notably can't reach lambdas whose types end up in inferred types via arguments like
Box([C^] => ...).This fix adds a type-level rule to both cleanup passes: a retains set referencing a type-lambda binder that lives inside the inferred type itself is provably un-re-inferable, so it's kept and processed as a declared type
Have you relied on LLM-based tools in this contribution?
Yes, and I checked the output by guiding and reviewing it.
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)
& testing in the REPL via
./bin/replQ.