fix(repl): -Xrepl-interrupt-instrumentation:local instrumenting nothing - #26960
Merged
Conversation
warcholjakub
requested review from
Gedochao and
SolalPirelli
and removed request for
SolalPirelli
September 1, 2026 12:15
Gedochao
approved these changes
Sep 1, 2026
Gedochao
left a comment
Gedochao
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left one comment on tests
Comment on lines
+158
to
+161
| @Test def onlyEnabledAndLocalInstrumentReplClasses(): Unit = | ||
| assertFalse("false", probeIsInterruptible(Disabled)) | ||
| assertTrue("true", probeIsInterruptible(Enabled)) | ||
| assertTrue("local", probeIsInterruptible(Local)) |
Contributor
There was a problem hiding this comment.
these should be 3 separate tests, IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
-Xrepl-interrupt-instrumentation:localbasically worked likefalse. I found the issue while working on a PR (I wanted to use the option but noticed it doesn't work like advertised).Have you relied on LLM-based tools in this contribution?
Yes, just for tests. I checked the output by reading and understanding the code.
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)