Fix Java record unapply crash under explicit nulls - #26975
Merged
olhotak merged 1 commit intoSep 4, 2026
Conversation
scala#26497 did not consider explicit nulls, specifically the flexible types that are added for Java varargs. This PR fixes a crash when using the unapply under explicit nulls.
tgodzik
approved these changes
Sep 3, 2026
tgodzik
left a comment
tgodzik
left a comment
Contributor
There was a problem hiding this comment.
LGTM I think there is a flaky test, rerunning it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26497 did not consider explicit nulls, specifically the flexible types that are added for Java varargs. This PR fixes a crash when using the generated unapply under explicit nulls.
Have you relied on LLM-based tools in this contribution?
Yes, and I checked fix and tests by hand.
How was the solution tested?
New automated tests