Repository navigation
Conversation
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.6 #6349 +/- ##
===================================================
- Coverage 90.73% 90.72% -0.02%
===================================================
Files 207 207
Lines 38913 38925 +12
===================================================
+ Hits 35308 35313 +5
- Misses 3605 3612 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
… has a key A key from an unconfigured KMS was stored and only rejected on the next write.
8844a76 to
854620d
Compare
| }); | ||
| }); | ||
|
|
||
| it('should refuse a KMSMasterKeyID of a KMS that is not configured and keep the config', done => { |
There was a problem hiding this comment.
Side note, not related to this PR: this test suite could benefit from being turned into async functions (with help of promisify).
|
@dvasilas since it's a bug fix I would have expected it to land in an older development branch than 9.6, is it expected? |
It was intentional, my intention is to land it on the newest branches because it is a minor one. |
|
Closing this because after discussion with Product we decided to change this in the other direction. |
When a bucket already had a bucket key,
PutBucketEncryptionstored theKMSMasterKeyIDwithout checking its ARN.It accepted a key for a KMS that wasn't configured, and every later write to the bucket using it failed with
InvalidArgument.It now rejects it with
InvalidArgumentwhenPutBucketEncryptionis called, as it does for a bucket without a key and for' CreateBucket'.