From 9f59177b83535e3bd109406c5115886e35ed12a1 Mon Sep 17 00:00:00 2001 From: mayeut Date: Sat, 20 Dec 2025 11:33:36 +0100 Subject: [PATCH 1/2] fix: force `BUILD_TESTING` to inherit `RUN_NINJA_TEST` value --- .github/workflows/build.yml | 2 +- CMakeLists.txt | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1d72218..7485d6a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -186,7 +186,7 @@ jobs: done - name: Install SDist - run: .venv/bin/pip install --no-binary=ninja $(ls sdist/*.tar.gz) + run: .venv/bin/pip install -v --no-binary=ninja $(ls sdist/*.tar.gz) - name: Test installed SDist run: .venv/bin/pip check && .venv/bin/pytest ./tests diff --git a/CMakeLists.txt b/CMakeLists.txt index 3e6fe0a..e0e783d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,6 +23,8 @@ message(STATUS "") message(STATUS " RUN_NINJA_TEST : ${RUN_NINJA_TEST}") message(STATUS "************************************") +set(BUILD_TESTING ${RUN_NINJA_TEST} CACHE INTERNAL "") + add_subdirectory(ninja-upstream) if(RUN_NINJA_TEST) From 223ce100dbb29697750751e4f7870e7fab0cba8d Mon Sep 17 00:00:00 2001 From: Matthieu Darbois Date: Sun, 30 Aug 2026 12:15:53 +0200 Subject: [PATCH 2/2] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e0e783d..ede1d52 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,8 @@ message(STATUS "") message(STATUS " RUN_NINJA_TEST : ${RUN_NINJA_TEST}") message(STATUS "************************************") -set(BUILD_TESTING ${RUN_NINJA_TEST} CACHE INTERNAL "") +set(BUILD_TESTING "${RUN_NINJA_TEST}" CACHE BOOL "Build the testing tree." FORCE) +set_property(CACHE BUILD_TESTING PROPERTY TYPE INTERNAL) add_subdirectory(ninja-upstream)