Repository navigation
fix: remove outdated ninja_syntax stub - #365
Merged
Merged
Conversation
The stub did not match the shipped ninja_syntax.py: it typed `output` as `str`, `build()` outputs as `list[str]` only, and gave `build()` no return type. Upstream annotates ninja_syntax.py, and the package has py.typed, so type checkers can use the real annotations and cannot drift again. Closes #344 Assisted-by: ClaudeCode:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
src/ninja/ninja_syntax.pyidid not match theninja_syntax.pymodule that the build installs:outputwasstrinstead of a file object,build()accepted onlylist[str]outputs, andbuild()had no return type.Upstream annotates
ninja_syntax.py, and the package includespy.typed. The stub is removed, so type checkers use the upstream annotations and the types cannot drift again.A test makes sure that no stub shadows the module and that the module keeps its annotations. mypy gets an override, because
ninja_syntax.pyis only present after a build.Closes #344