chore: update pre-commit hooks - #1694
Merged
Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: c59bba8fb259db0fec2bbb77ad8ba51ea7341b56 → 39d9ac5938dadb73df0564a45f163e25ff9fa6e2](astral-sh/ruff-pre-commit@c59bba8...39d9ac5) - [github.com/zizmorcore/zizmor-pre-commit: e3eebf65325ccc992422292cb7a4baee967cf815 → 451b56af716f9f0d0c2b816503a3fd0cf8b036fa](zizmorcore/zizmor-pre-commit@e3eebf6...451b56a)
Codecov Report❌ Patch coverage is
Additional details and impacted files
|
Ruff 0.16 greatly expanded its implicit default rule set, which surfaced 84 new errors (BLE001, DTZ, N999, S102, S110, TRY002/TRY004) that are either intentional in uproot or would require user-visible behavior changes. Pin `lint.select` to the previous default so the enabled rules stay the ones listed in `extend-select`, and document the triage inline. Also revert the PYI019 autofix in `_dask.py`: it introduced a top-level `from typing_extensions import Self`, but typing_extensions is not a declared dependency and `typing.Self` does not exist on Python 3.10. Adopt the four new-default findings that are safe to fix outright, and enable those rules individually: - FURB132: use `set.discard` instead of check-and-remove - FURB163: use `math.log10` instead of `math.log` with a redundant base - PERF102: don't use `dict.items()` when only the keys are used - PYI025: alias `collections.abc.Set` as `AbstractSet` Assisted-by: claude-code:claude-opus-5
ariostas
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: