Repository navigation
Conversation
* `DragRect` never actually stored a user specified callback & was always defaulting to `None` * `FlexibleRect` never called `redraw_callback` when respanning
Height was being adjusted correctly but was never shifted to the new lower y bound so it never spanned the whole plot
Horizontal lines had been accidentally validating against the snapto's xdata. This was masked in the tests by the dummy line having the same x & y data.
More generic implementation of the timedelta-specific fix for #8
When plotting data, matplotlib performs an implicit float conversion to move the xy data into native axis data. Since we already have to track this change to support snap checking, we might as well loosen the input constraints across the board
Rearrange test suite
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[v1.2.0]
Added
FlexibleRectChanged
NaNawareness to prevent unexpected behavior when working with datasets containing gapsposition, andwindow_width; all types that matplotlib can plot should also be meaningfully supportedFixed
DragRectcompletely ignoring user-specified redraw callbacksFlexibleRectnot calling the redraw callback when respanningDragRecton axis limit changeDragLineaccidentally validatingsnap_toagainst xdata for vertical lines