Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ description = "Put Scrapy spiders behind an HTTP API"
dependencies = [
"scrapy>=2.7",
"packaging>=20.0",
'typing-extensions>=4.5.0; python_version < "3.13"',
]
classifiers = [
"Development Status :: 5 - Production/Stable",
Expand Down
24 changes: 12 additions & 12 deletions scrapyrt/core.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import datetime as dt
import sys
from collections import OrderedDict
from copy import deepcopy
from pathlib import Path
Expand All @@ -17,6 +18,15 @@
from .conf.spider_settings import get_project_settings, get_scrapyrt_settings
from .log import setup_spider_logging

if sys.version_info >= (3, 13):
from warnings import deprecated
else:
from typing_extensions import deprecated

_START_REQUESTS_DEPRECATED = (
"CrawlManager.start_requests is deprecated, use CrawlManager.spider_start instead."
)


class ScrapyrtCrawlerRunner(CrawlerRunner):
def __init__(self, settings, scrapyrt_manager):
Expand Down Expand Up @@ -107,23 +117,13 @@ def _init_spider_start(self, start_requests, spider_start):
self.spider_start = spider_start

@property
@deprecated(_START_REQUESTS_DEPRECATED)
def start_requests(self):
warn(
"CrawlManager.start_requests is deprecated, use "
"CrawlManager.spider_start instead.",
DeprecationWarning,
stacklevel=2,
)
return self.spider_start

@start_requests.setter
@deprecated(_START_REQUESTS_DEPRECATED)
def start_requests(self, value: bool):
warn(
"CrawlManager.start_requests is deprecated, use "
"CrawlManager.spider_start instead.",
DeprecationWarning,
stacklevel=2,
)
self.spider_start = value

def crawl(self, *args, **kwargs):
Expand Down
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ deps =
# DeprecationWarning: twisted.web.http.HTTPClient was deprecated in
# Twisted 24.7.0: Use twisted.web.client.Agent instead.
Twisted<24.7.0
typing-extensions==4.5.0


[testenv:coverage]
Expand Down
Loading