Skip to content

Add benchmarks and regenerate the parser comparison from measurements - #83

Merged
wRAR merged 3 commits into
scrapy:masterfrom
AdrianAtZyte:benchmarks
Sep 3, 2026
Merged

Add benchmarks and regenerate the parser comparison from measurements#83
wRAR merged 3 commits into
scrapy:masterfrom
AdrianAtZyte:benchmarks

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Contributor

This should be nice on its own provided it works as expected, and the benchmarks I think we should have before considering #47, which may no longer apply since we only use regular expressions in 1 place now.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.64%. Comparing base (4ec7701) to head (ff222ad).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files           5        5           
  Lines         382      382           
  Branches       78       78           
=======================================
  Hits          373      373           
  Misses          5        5           
  Partials        4        4           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Congrats! CodSpeed is installed 🎉

🆕 2 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


Open in CodSpeed

@AdrianAtZyte AdrianAtZyte reopened this Aug 6, 2026
@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review August 6, 2026 10:44
@wRAR
wRAR merged commit d8ec583 into scrapy:master Sep 3, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants