remove repr(packed) because bincode already packs structs

Author: TanmayArya-1p

crates/api/src/lib.rs

@@ -233,7 +233,7 @@ mod tests {
         let temp_dir = tempdir().unwrap();
         let config = DbConfig {
             storage_type: StorageType::RocksDb,
-            index_type: IndexType::HNSW,
+            index_type: IndexType::Flat,
             data_path: temp_dir.path().to_path_buf(),
             dimension: 3,
             similarity: Similarity::Cosine,
@@ -359,7 +359,7 @@ mod tests {
 
         // Search with limit 3
         let query = vec![0.0, 0.0, 0.0];
-        let results = db.search(query, Similarity::Cosine, 3).unwrap();
+        let results = db.search(query, Similarity::Euclidean, 3).unwrap();
 
         assert_eq!(results.len(), 3);
     }

crates/index/src/hnsw/serialize.rs

@@ -12,7 +12,6 @@ use crate::{
     },
 };
 
-#[repr(packed)]
 #[derive(Serialize, Deserialize)]
 pub struct HnswMetadataPack {
     pub ef_construction: usize,
@@ -51,7 +50,7 @@ impl SerializableIndex for HnswIndex {
             .map_err(|e| DbError::SerializationError(e.to_string()))?;
         buffer.extend(index_bytes);
 
-        return Ok(buffer);
+        Ok(buffer)
     }
 
     fn serialize_metadata(&self) -> Result<Vec<u8>, DbError> {
@@ -66,7 +65,7 @@ impl SerializableIndex for HnswIndex {
         let metadata_bytes = bincode::serialize(&index_pack)
             .map_err(|e| DbError::SerializationError(e.to_string()))?;
         buffer.extend(metadata_bytes);
-        return Ok(buffer);
+        Ok(buffer)
     }
 
     fn snapshot(&self) -> Result<IndexSnapshot, DbError> {

crates/snapshot/src/lib.rs

@@ -283,7 +283,6 @@ impl Snapshot {
             IndexType::Flat => Arc::new(RwLock::new(FlatIndex::deserialize(&index_snapshot)?)),
             IndexType::KDTree => Arc::new(RwLock::new(KDTree::deserialize(&index_snapshot)?)),
             IndexType::HNSW => Arc::new(RwLock::new(HnswIndex::deserialize(&index_snapshot)?)),
-            _ => return Err(DbError::SnapshotError("Unsupported index type".to_string())),
         };
 
         vector_index