fablish fragmentalisation

Author: sekuba

.github/workflows/deploy.yml

@@ -50,7 +50,7 @@ jobs:
 
       - name: Require HTTPS endpoints for the PWA
         env:
-          PUBLIC_API_ORIGIN: https://api.slashveto.me
+          PUBLIC_API_ORIGIN: ${{ vars.VITE_API_BASE_URL || 'https://api.slashveto.me' }}
           MAINNET_L1_RPC_URL: ${{ vars.VITE_L1_RPC_URL }}
           TESTNET_L1_RPC_URL: ${{ vars.VITE_TESTNET_L1_RPC_URL }}
         run: |
@@ -64,17 +64,14 @@ jobs:
             fi
           }
 
-          if [[ -z "$PUBLIC_API_ORIGIN" || "$PUBLIC_API_ORIGIN" != https://* || "$PUBLIC_API_ORIGIN" == *,* ]]; then
-            echo "VITE_API_BASE_URL must be one public HTTPS API origin."
-            exit 1
-          fi
+          require_https_url VITE_API_BASE_URL "$PUBLIC_API_ORIGIN"
           require_https_url VITE_L1_RPC_URL "$MAINNET_L1_RPC_URL"
           require_https_url VITE_TESTNET_L1_RPC_URL "$TESTNET_L1_RPC_URL"
 
       - name: Lint, test, syntax-check, and build
         run: pnpm check
         env:
-          VITE_API_BASE_URL: https://api.slashveto.me
+          VITE_API_BASE_URL: ${{ vars.VITE_API_BASE_URL || 'https://api.slashveto.me' }}
           VITE_BASE_PATH: ${{ vars.VITE_BASE_PATH || '/' }}
           VITE_L1_RPC_URL: ${{ vars.VITE_L1_RPC_URL }}
           VITE_REGISTRY_ADDRESS: ${{ vars.VITE_REGISTRY_ADDRESS }}

README.md

@@ -32,8 +32,9 @@ and action order, never by address and approximate time.
 
 ## Repository
 
-- `shared/protocol/` contains the pure case projection, tallying, transitions,
-  and notification wording shared by frontend and backend.
+- `shared/protocol/` contains the pure case projection, vote tallying, round
+  lifecycle, transitions, and notification wording shared by frontend and
+  backend.
 - `src/` contains the React PWA and independent browser L1 collector.
 - `collector/` contains the Node backend, SQLite repository, three evidence
   collectors, API, durable outbox, Telegram, and Web Push.

collector/deploy/slashmon-backend-testing.env.example

@@ -1,4 +1,6 @@
 # Install as /etc/slashmon-backend-testing.env with mode 0600.
+# Set SLASHMON_NETWORK=testnet when this instance should track testnet.
+# SLASHMON_NETWORK=testnet
 SLASHMON_PUBLIC_URL=https://testing.slashveto.me
 BACKEND_CORS_ORIGIN=https://testing.slashveto.me
 BACKEND_BIND_HOST=127.0.0.1

collector/src/admin-client.mjs

@@ -126,9 +126,12 @@ export class AztecAdminClient {
       });
     } catch (error) {
       if (requestSignal.aborted && !signal?.aborted) {
-        throw new Error(`${request.label} request timed out after ${this.timeoutMs}ms`);
+        throw new Error(`${request.label} request timed out after ${this.timeoutMs}ms`, { cause: error });
       }
-      throw new Error(`${request.label} request failed: ${error instanceof Error ? error.message : String(error)}`);
+      throw new Error(
+        `${request.label} request failed: ${error instanceof Error ? error.message : String(error)}`,
+        { cause: error },
+      );
     }
 
     const responseLimit = method === 'aztec_getValidatorStats'
@@ -172,8 +175,8 @@ export function parseNodeInfo(value) {
   }
   return {
     l1ChainId: parseChainId(value.l1ChainId),
-    registryAddress: parseIdentityAddress(contracts.registryAddress, 'registryAddress'),
-    rollupAddress: parseIdentityAddress(contracts.rollupAddress, 'rollupAddress'),
+    registryAddress: parseAddress(contracts.registryAddress, 'node info registryAddress'),
+    rollupAddress: parseAddress(contracts.rollupAddress, 'node info rollupAddress'),
   };
 }
 
@@ -337,13 +340,6 @@ function parseChainId(value) {
   return parsed;
 }
 
-function parseIdentityAddress(value, name) {
-  if (typeof value !== 'string' || !/^0x[0-9a-fA-F]{40}$/.test(value) || /^0x0{40}$/i.test(value)) {
-    throw new Error(`Aztec node info ${name} must be a nonzero 20-byte hex address`);
-  }
-  return value.toLowerCase();
-}
-
 function parseAddress(value, label) {
   if (typeof value !== 'string' || !/^0x[0-9a-fA-F]{40}$/.test(value) || /^0x0{40}$/i.test(value)) {
     throw new Error(`Aztec ${label} must be a nonzero 20-byte hex address`);

collector/src/case-api-server.mjs

@@ -110,6 +110,8 @@ export class CaseApiServer {
     if (!this.server.listening) return Promise.resolve();
     return new Promise((resolve, reject) => {
       this.server.close((error) => error ? reject(error) : resolve());
+      // Keep-alive sockets otherwise hold close() open until they idle out.
+      this.server.closeIdleConnections();
     });
   }
 
@@ -215,6 +217,7 @@ export class CaseApiServer {
           addresses,
           now: this.now(),
         });
+        if (!updated) throw new InputError('watch_not_found', 'Watch not found', 404);
         return this.send(request, response, 200, publicWatch(updated, this.repository));
       }
       if (request.method === 'DELETE') {