Repository navigation
refactor(gateway): pass REST configuration to the HTTP layer as values - #747
Merged
bburda merged 2 commits intoOct 24, 2026
Merged
Conversation
mfaferek93
reviewed
Oct 23, 2026
mfaferek93
approved these changes
Oct 24, 2026
Server, SSE and docs parameters are read once at startup and handed to the HTTP layer as plain values. Document that they are not reloaded at runtime.
The REST configuration read server.host and server.port straight from the parameters, while the listener binds the validated values. With server.port set to 80 the listener fell back to 8080 and the OpenAPI servers URL still said port 80. The configuration now takes server_host_ and server_port_. The try/catch blocks around server.host, server.port and docs.enabled are gone, because the node always declares these parameters.
bburda
force-pushed
the
feat/gateway-core-2-config-values
branch
from
October 24, 2026 11:33
b951a0e to
77c9f2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The server, SSE and docs parameters are read once at startup and given to the HTTP layer as plain values.
docs/config/server.rstsays that they are not reloaded at runtime.Issue
Type
Testing
./scripts/test.sh unit --packages-select ros2_medkit_gatewayChecklist