Repository navigation
refactor(gateway): reach message, service and action schemas through a TypeSchemaProvider interface - #750
Merged
bburda merged 2 commits intoOct 24, 2026
Conversation
mfaferek93
reviewed
Oct 23, 2026
mfaferek93
approved these changes
Oct 24, 2026
…a TypeSchemaProvider interface Handlers read type schemas through a ROS-free provider. The type_info copy for services and actions stays inside its error handling.
The type schema provider logs a failed lookup under its own logger with the type name only. The data and operation handlers now log the miss at DEBUG under rest_server with the topic or type, and the topic transport logs it under the node logger, so --log-level rest_server:=debug shows which topic has no schema.
bburda
force-pushed
the
feat/gateway-core-5-type-schema
branch
from
October 24, 2026 11:33
87a5bd7 to
eb745b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The handlers read the schemas of messages, services and actions through
TypeSchemaProvider, a ROS-free interface. The ROS side implements it. The copy oftype_infofor services and actions stays inside its error handling.Issue
Type
Testing
./scripts/test.sh unit --packages-select ros2_medkit_gatewaysrc/ros2_medkit_gateway/scripts/check_core_purity.shChecklist