Repository navigation
Conversation
…n samplers
register_builtin_samplers() registers data, faults, configurations, logs and updates from GatewayServices, so a program that hosts the core gets samplers without the ROS node. The data sampler reads through the same provider resolution as GET /{entity}/data/{item}, so plugin-served data can be subscribed to.
…he categories the host serves BulkDataConfig and make_bulk_data_store() build the store from the bulk_data settings, and the node uses them. The rosbags category is listed only when the fault manager transport serves rosbags, and GET / reports bulk_data and cyclic_subscriptions only when the host provides a store or rosbags, and a transport and a sampler.
…an unknown category The bulk-data list and download routes take the rosbags path only when the fault manager serves rosbags. Otherwise the category falls through to the store check and answers 404 Unknown category.
…-9-core-sampling-bulkdata
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The built-in cyclic-subscription samplers (
data,faults,configurations,logs,updates) move from the node into the core:register_builtin_samplers(GatewayServices &). Thedatasampler reads an item the same wayGET /{entity}/data/{id}does, so data served by a pluginDataProvidercan be sampled too.The core builds the bulk-data store from
BulkDataConfig(thebulk_data.*names and defaults). Therosbagscategory is listed only when the fault manager serves rosbags (FaultServiceTransport::serves_rosbags(), default true), and otherwise answers like an unknown category.GET /reportsbulk_dataandcyclic_subscriptionsfrom the services the host provides. The ROS 2 node keeps its behaviour.Issue
Type
Testing
scripts/check_cores_without_ros/run.shbuilds the core with gcc 9 and no ROS, starts its REST server and checks subscriptions on topic data, plugin data and faults (two SSE events with changing values), bulk-data upload, list, download and delete, therosbagsanswer and the capabilities../scripts/test.sh integ --packages-select ros2_medkit_integration_testscovers the ROS 2 node path (subscriptions and bulk-data tests).Checklist