Run the e2e suite against the gateway release the app targets - #104
Open
bburda wants to merge 1 commit into
Open
Run the e2e suite against the gateway release the app targets#104bburda wants to merge 1 commit into
bburda wants to merge 1 commit into
Conversation
The stack pinned a gateway image built in July, from before the script request bodies were tightened. The specs that cover uploading and running a script therefore passed without exercising the contract the app is written against: the old gateway accepts the body either way, so a regression in how the app builds it would not show up here. The pin moves to gateway 0.7.0. It stays a digest rather than a tag, because tags on this registry are mutable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The Playwright stack pinned a gateway image built in July, which reports version 0.6.0. Gateway 0.7.0 tightened both script request bodies - the upload body declares a required
filepart, the execution body isScriptExecutionRequestwithexecution_typerequired - and the app was adapted to that. The specs covering upload, run and delete were still running against the older gateway, which accepts either body shape, so they passed without exercising the contract the app is written against.The pin moves to gateway 0.7.0. It stays a digest rather than a tag, because tags on this registry are mutable and a re-run of the publishing workflow on the same commit moves one.
docker-compose.rosbag.ymlalready tracks:latestthrough an overridable variable, so it needed no change.Issue
Type
Testing
The digest was resolved from the registry and the image was started and asked directly:
GET /api/v1/reports0.7.0.The suite itself is verified by this PR's own
e2ejob, which is the point of the change - it is the first run of these specs against a gateway that enforces the tightened bodies. Locally the same specs pass against a 0.7.0 gateway built from the release tag (21 passed, 3 skipped, the rosbag project needing its own stack).Checklist
npm run lint)npm run build)