lang: fix c-sharp-pro fyi.list to reference its own submodule - #618
Draft
malaverdiere wants to merge 1 commit into
Draft
lang: fix c-sharp-pro fyi.list to reference its own submodule#618malaverdiere wants to merge 1 commit into
malaverdiere wants to merge 1 commit into
Conversation
c-sharp-pro/fyi.list was a byte-for-byte copy of c-sharp/fyi.list, listing tree-sitter-c-sharp instead of the separately-pinned tree-sitter-c-sharp-pro submodule that c-sharp-pro's generation actually reads from (lang/semgrep-grammars/src/semgrep-c-sharp-pro/prep). This meant fyi.list-scoped checks (attribution copying, submodule drift detection) silently ignored the submodule this language really depends on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lang/c-sharp-pro/fyi.listwas a byte-for-byte copy oflang/c-sharp/fyi.list, listingtree-sitter-c-sharppaths instead of the separately-pinnedtree-sitter-c-sharp-prosubmodule.lang/semgrep-grammars/src/semgrep-c-sharp-pro/prepactually reads fromtree-sitter-c-sharp-produring generation, so anything scoped byfyi.list(attribution file copying inlang/release, and submodule drift detection) was silently checking the wrong submodule for this language.Test plan
tree-sitter-c-sharp-pro/LICENSE,tree-sitter-c-sharp-pro/grammar.js,semgrep-c-sharp-pro/grammar.js) exist on disk.