semgrep · tean-lai · Jul 14, 2026 · Jul 14, 2026 · Jul 14, 2026 · Jul 14, 2026
@@ -23,7 +23,7 @@ extension grammar and its tests.**
 
 ## Inputs
 
-- **`<lang>`** — the `test-lang` argument (e.g. `javascript`, `solidity`). The
+- **`<lang>`** — the `test-lang` argument (e.g. `typescript`, `solidity`). The
   sublanguage set it builds is hardcoded in the `sublangs=` block of
   `lang/test-lang` — read it there; usually it's just the lang itself. Steps
   1, 3, and 5 act on whichever directories it builds.
@@ -263,7 +263,7 @@ auto-merge.
 ## Running by hand
 
 From the repo, give the agent the language and this skill, e.g.
-`Use fix-semgrep-grammar to make test-lang javascript pass.` — optionally with
+`Use fix-semgrep-grammar to make test-lang typescript pass.` — optionally with
 a tighter cap, e.g. `... pass, with max-iterations 5.` Under the Claude Agent
 SDK (e.g. a Python GitHub Action), keep the hard limits (`max_turns`, budget,
 an outer `timeout`) at the harness level — `max-iterations` bounds only the fix

@@ -62,7 +62,6 @@ ocaml-tree-sitter-semgrep](https://github.com/returntocorp/ocaml-tree-sitter-sem
 * [hcl](https://github.com/returntocorp/semgrep-hcl)
 * [html](https://github.com/returntocorp/semgrep-html)
 * [java](https://github.com/returntocorp/semgrep-java)
-* [javascript](https://github.com/returntocorp/semgrep-javascript)
 * [jsonnet](https://github.com/returntocorp/semgrep-jsonnet)
 * [julia](https://github.com/returntocorp/semgrep-julia)
 * [kotlin](https://github.com/returntocorp/semgrep-kotlin)

@@ -35,7 +35,6 @@ SUPPORTED_TS_LANGUAGES = \
   hcl \
   html \
   java \
-  javascript \
   jsonnet \
   julia \
   kotlin \
@@ -91,7 +90,6 @@ SUPPORTED_DIALECTS = \
   html \
   java \
   julia \
-  javascript \
   jsonnet \
   julia \
   kotlin \

@@ -1 +1 @@
-../src/semgrep-javascript
+../src/semgrep-typescript/javascript
@@ -8,6 +8,12 @@ echo `pwd`
 
 # Put all the C files in the same folder to facilitate packaging
 # for ocaml/dune.
+mkdir -p javascript/src
+ln -sf ../../common/scanner.h javascript/src
+cat ../tree-sitter-javascript/src/scanner.c \
+  | sed -e 's:"../../common/scanner.h":"scanner.h":' \
+  > javascript/src/scanner.c
+
 mkdir -p typescript/src
 ln -sf ../../common/scanner.h typescript/src
 cat ../tree-sitter-typescript/typescript/src/scanner.c \
@@ -20,6 +26,11 @@ cat ../tree-sitter-typescript/tsx/src/scanner.c \
   | sed -e 's:"../../common/scanner.h":"scanner.h":' \
   > tsx/src/scanner.c
 
+mkdir -p javascript/corpus
+rm -f javascript/corpus/inherited
+ln -sf ../../../tree-sitter-javascript/test/corpus \
+   javascript/corpus/inherited
+
 mkdir -p typescript/corpus
 rm -f typescript/corpus/inherited
 ln -sf ../../../tree-sitter-typescript/typescript/corpus \

@@ -62,7 +62,7 @@ sublangs="$lang"
 # It could be handled in a generic fashion by declaring the list of
 # dialects for each tree-sitter-X project.
 if [[ "$lang" = typescript ]]; then
-  sublangs="typescript tsx"
+  sublangs="javascript typescript tsx"
 elif [[ "$lang" = php ]]; then
   sublangs="php php-only"
 elif [[ "$lang" = sfapex ]]; then
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		../src/semgrep-javascript
		../src/semgrep-typescript/javascript
nmote Jul 14, 2026 Copy link Copy Markdown Member Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Probably less confusing to just remove this symlink altogether tean-lai Jul 15, 2026 Copy link Copy Markdown Contributor Author Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. The plan was to archive semgrep-javascript, but I seem to have insufficient perms at the moment. Keeping the symlink seems to be more consistent with other stuff. Thinking particularly of `tsx`, which we treat as a sublang of typescript already, but that similarly symlinks to `semgrep-typescript/tsx`. It also seems like the `test-lang` script depends on the existence of this symlink.