fix: stop ignoring core/src/bindings in .gitignore - #661
Open
malaverdiere wants to merge 1 commit into
Open
Conversation
A bare bindings/ pattern also matched the hand-written OCaml C API library at core/src/bindings. gitignore-to-dockerignore then excluded it from Docker build contexts, breaking semgrep-core builds with Library "tree-sitter.bindings" not found. Co-authored-by: Cursor <cursoragent@cursor.com>
tean-lai
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bindings/gitignore pattern to/lang/**/bindings/socore/src/bindings(the OCaml C API library) is not ignored.bindings/was being copied into semgrep dockerignores via gitignore-to-dockerignore, which excluded the library from Docker build contexts and broke builds withLibrary "tree-sitter.bindings" not found.Test plan
core/src/bindingsis still trackedmake corefindstree-sitter.bindingsMade with Cursor