Update LICENSE - #662
Conversation
In preparation for integration in semgrep and semgrep-proprietary. History review shows that changes originated from r2c/Semgrep employees or contributors signed the CLA.
kopecs
left a comment
kopecs
left a comment
There was a problem hiding this comment.
I don't understand why we're trying to change this here. We can just merge this repo into the main one without changing external license terms.
|
@malaverdiere can you explain the motivation for the licence change? (edit: beaten by cooper) |
|
We're going to merge this in the main repo. Until it is merged, we'll have it as a git submodule. I'd like to merge the transition gradually, to avoid a big merge that goes wrong. So we'd have a submodule under GPL in the repo (under OSS/) and I'm not sure what are the implications. The alternative is to remove the LICENSE file and switch from gitmodule to in-repo files earlier in the process. I would however not update the internal scripts until I'm done merging the semgprep-LANG repos. So if you're comfortable with the fact that things are a bit inconsistent, then that plan works. |
|
I think it is totally fine to keep the external license for the OCaml stuff here as GPL while merging this in and we can worry about any modification subsequent. So I would rather keep the contents of this as-is and then revisit. |
3 participants
In preparation for integration in semgrep and semgrep-proprietary. History review shows that changes originated from r2c/Semgrep employees or contributors signed the CLA.
r2c/Semgrep current and former employees:
Signed CLA
Indeterminate
Duncan Hutty
Still present in repo, but not copyrightable: lang/hcl/extensions.txt line 3 — .hcl
Jacques Pienaar
One line left in repo rewritten in this branch.
Mehdi Bouaziz
Still present in repo, but not copyrightable: lang/ocaml/projects.txt line 32
Checklist