Dissolve coverage_gaps_test.go into the themed test files - #609
Merged
Conversation
The file was named for the process that produced it, not for what it pins — meaningless to a future reader. The feed lifecycle test joins axfr_test.go; the response-action, neutral-gate, and decoded-path tests join sidecar_test.go with the serve helper they share. No test changed.
m3ok
approved these changes
Sep 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 87.10% 87.06% -0.05%
==========================================
Files 182 182
Lines 23108 23108
==========================================
- Hits 20129 20119 -10
- Misses 2969 2979 +10
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file name described the session that produced the tests, not the behavior they pin — process-bound naming, the class we flag in review. Rather than rename it, the file dissolves into where each test belongs: the AXFR run-loop lifecycle joins
axfr_test.go; the response-action, neutral-gate, and decoded-path tests joinsidecar_test.goalongside the harness helper they share. Pure move — no test logic changed; suite, vet, and lint clean.