Group media data into a struct + add getters/setters for the entire struct - #412
Open
nicoburns wants to merge 1 commit into
Open
Group media data into a struct + add getters/setters for the entire struct#412nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
nicoburns
force-pushed
the
better-media-update-api
branch
from
August 24, 2026 22:20
bbfa9ca to
3fa0f84
Compare
jdm
approved these changes
Aug 26, 2026
jdm
left a comment
jdm
left a comment
Member
There was a problem hiding this comment.
Agreed; I think the current code is only going to expand over time so this is an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is aimed at trying to reduce the proliferation of getters/setters for individual media data properties by:
It also (IMO) makes the
Deviceconstructor a lot nicer as you get field names rather than having to try to match up function parameter order.In future we could consider removing the individual getters/setters (or making them private where they are called internally by Stylo), but this PR does not yet do that.
This PR is implemented on top of:
Device#410