Change createPara function to receive structured arguments

Author: PrithviKV

src/backend/lib/db_helpers/case_manager.ts

@@ -4,35 +4,36 @@ import { getTransporter } from "@/backend/lib/nodemailer";
 import { user } from "zapatos/schema";
 import { UserType } from "@/types/auth";
 
-interface paraInputProps {
-  first_name: string;
-  last_name: string;
-  email: string;
+interface createParaProps {
+  para: {
+    first_name: string;
+    last_name: string;
+    email: string;
+  };
+  db: KyselyDatabaseInstance;
+  case_manager_name: string;
+  from_email: string;
+  to_email: string;
+  env: Env;
 }
-
 /**
  * Checks for the existence of a user with the given email, if
  * they do not exist, create the user with the role of "para",
  * initiate email sending without awaiting result
  */
 export async function createPara(
-  para: paraInputProps,
-  db: KyselyDatabaseInstance,
-  case_manager_name: string,
-  from_email: string,
-  to_email: string,
-  env: Env
+  paraProps: createParaProps
 ): Promise<user.Selectable> {
-  const { first_name, last_name, email } = para;
+  const { first_name, last_name, email } = paraProps.para;
 
-  let paraData = await db
+  let paraData = await paraProps.db
     .selectFrom("user")
     .where("email", "=", email.toLowerCase())
     .selectAll()
     .executeTakeFirst();
 
   if (!paraData) {
-    paraData = await db
+    paraData = await paraProps.db
       .insertInto("user")
       .values({
         first_name,
@@ -45,11 +46,11 @@ export async function createPara(
 
     // promise, will not interfere with returning paraData
     void sendInviteEmail(
-      from_email,
-      to_email,
+      paraProps.from_email,
+      paraProps.to_email,
       first_name,
-      case_manager_name,
-      env
+      paraProps.case_manager_name,
+      paraProps.env
     );
   }
 

src/backend/routers/case_manager.ts

@@ -320,14 +320,19 @@ export const case_manager = router({
       })
     )
     .mutation(async (req) => {
-      const para = await createPara(
-        req.input,
-        req.ctx.db,
-        req.ctx.auth.session.user?.name ?? "",
-        req.ctx.env.EMAIL_FROM,
-        req.input.email,
-        req.ctx.env
-      );
+      const paraProps = {
+        para: {
+          first_name: req.input.first_name,
+          last_name: req.input.last_name,
+          email: req.input.email,
+        },
+        db: req.ctx.db,
+        from_email: req.ctx.env.EMAIL_FROM,
+        to_email: req.input.email,
+        case_manager_name: req.ctx.auth.session.user?.name ?? "",
+        env: req.ctx.env,
+      };
+      const para = await createPara(paraProps);
 
       return await assignParaToCaseManager(
         para.user_id,

src/backend/routers/para.ts

@@ -46,14 +46,14 @@ export const para = router({
     .mutation(async (req) => {
       const { email } = req.input;
 
-      const para = await createPara(
-        req.input,
-        req.ctx.db,
-        req.ctx.auth.session.user?.name ?? "",
-        req.ctx.env.EMAIL_FROM,
-        email,
-        req.ctx.env
-      );
+      const para = await createPara({
+        para: req.input,
+        db: req.ctx.db,
+        case_manager_name: req.ctx.auth.session.user?.name ?? "",
+        from_email: req.ctx.env.EMAIL_FROM,
+        to_email: email,
+        env: req.ctx.env,
+      });
       return para;
 
       // TODO: Logic for sending email to staff. Should email be sent everytime or only first time? Should staff be notified that they are added to a certain case manager's list?