scrub database dump: implement Heroku client and postgres client (2/3) - #224
Open
odo-sfct wants to merge 2 commits into
Open
scrub database dump: implement Heroku client and postgres client (2/3)#224odo-sfct wants to merge 2 commits into
odo-sfct wants to merge 2 commits into
Conversation
This was referenced Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 | Part 2 | Part 3
Opted for writing in python over a shell script for error handling and integration with Django's base commands which can take care of connecting to the ORM + maintainability of python over shell scripts.
The heroku client can in the future be expanded to use the API or other CLI tools for other downstream scripts.
Implementation creates a temporary database so that the process is "transactional" in nature. There won't be partial state, or PII getting into the target device unless the full process is successful.
It was much easier to leverage Djangos ORM and faker library if built in python over a shell script.