Skip to content

Commit 59f44f1

Browse files
authored
[#50] Fix wrapping in footer
Put a Group around the Anchors in the footer so that they flex on one line, with space between. Remove the h prop on the Footer in App.jsx, since that was causing some blank space if the footer content wasn't exactly that height. Add missing prop-types and uuid packages.
1 parent 71f60b0 commit 59f44f1

4 files changed

Lines changed: 13 additions & 5 deletions

File tree

client/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,13 @@
2727
"i18next-http-backend": "^3.0.2",
2828
"inflection": "^3.0.2",
2929
"luxon": "^3.7.2",
30+
"prop-types": "^15.8.1",
3031
"react": "^19.1.1",
3132
"react-dom": "^19.1.1",
3233
"react-dropzone-esm": "^15.2.0",
3334
"react-i18next": "^16.0.0",
34-
"react-router": "^7.9.1"
35+
"react-router": "^7.9.1",
36+
"uuid": "^9.0.1"
3537
},
3638
"devDependencies": {
3739
"@types/react": "^19.1.13",

client/src/App.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ function App () {
8080
/>
8181
</Routes>
8282
</AppShell.Main>
83-
<AppShell.Footer pos='relative' h='12.875rem' bd='none' bg='var(--mantine-color-light-background)'>
83+
<AppShell.Footer pos='relative' bd='none' bg='var(--mantine-color-light-background)'>
8484
<Footer />
8585
</AppShell.Footer>
8686
</AppShell>

client/src/Footer.jsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Anchor, Container, Image, Text } from '@mantine/core';
1+
import { Anchor, Container, Group, Image, Text } from '@mantine/core';
22
import { Link } from 'react-router';
33
import { useTranslation } from 'react-i18next';
44

@@ -9,7 +9,11 @@ function Footer () {
99
<Text mb='.75rem' fz='xs' lh='1rem' c='var(--mantine-color-text-secondary)'>{t('footer.providedBy')}</Text>
1010
<Image mb='.5rem' src='/assets/sfcivictech.png' w={138} />
1111
<Text fz='sm'>{t('footer.partnershipLine1')}<br />{t('footer.partnershipLine2')}</Text>
12-
<Anchor component={Link} td='underline' fz='sm' to='https://sf.gov/LVProgram'>{t('footer.permitProgramSite')}</Anchor> <Anchor component={Link} ms='xl' td='underline' fz='sm' to='/privacy'>{t('footer.privacyPolicy')}</Anchor> <Anchor component={Link} ms='xl' td='underline' fz='sm' to='/disclaimer'>{t('footer.disclaimer')}</Anchor>
12+
<Group justify='space-between' align='center' gap='0'>
13+
<Anchor component={Link} td='underline' fz='sm' to='https://sf.gov/LVProgram'>{t('footer.permitProgramSite')}</Anchor>
14+
<Anchor component={Link} td='underline' fz='sm' to='/privacy'>{t('footer.privacyPolicy')}</Anchor>
15+
<Anchor component={Link} td='underline' fz='sm' to='/disclaimer'>{t('footer.disclaimer')}</Anchor>
16+
</Group>
1317
</Container>
1418
);
1519
}

package-lock.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)