Fix wrapping in footer - #50
Merged
Merged
Conversation
Put a Group around the Anchors in the footer so that they flex on one line, with space between. Remove the h prop on the Footer in App.jsx, since that was causing some blank space if the footer content wasn't exactly that height. Add missing prop-types and uuid packages.
francisli
approved these changes
Oct 1, 2025
francisli
left a comment
francisli
left a comment
Contributor
There was a problem hiding this comment.
I'm fine to approve and merge this in, but what does adding prop-types do here? I thought React was moving away from prop-types:
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops
Contributor
|
@fwextensions nevermind, I see the components that still reference prop-types... will clean that out in the future... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put a Group around the Anchors in the footer so that they flex on one line, with space between.
Remove the h prop on the Footer in App.jsx, since that was causing some blank space if the footer content wasn't exactly that height.
Add missing prop-types and uuid packages.
Initial issue:
