Skip to content

Bump React on Rails to 17.1.0 - #27

Merged
justin808 merged 1 commit into
mainfrom
jg/bump-react-on-rails-17-1-0
Sep 19, 2026
Merged

justin808 merged 1 commit into
mainfrom
jg/bump-react-on-rails-17-1-0

Conversation

@justin808

@justin808 justin808 commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

🤖 Cursor · Grok 4.6 · medium

Summary

  • Pin this demo to the published React on Rails 17.1.0 gems and npm packages (and react-on-rails-rsc 19.3.0 where this app already consumed RSC).
  • Refresh lockfiles so clone-and-run matches the 17.1.0 release instead of leftover RC pins.

Test plan

  • Hosted CI on this head
  • Install/build for this repo's package manager
  • Manifest smoke paths if a review app is configured

Summary by CodeRabbit

  • Chores
    • Updated the React on Rails integration to version 17.1.0.

Leave leftover RC pins behind so clone-and-run examples match the published gems and npm packages.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d99dd011-7989-4428-80e7-4b11cb15ccfe

📥 Commits

Reviewing files that changed from the base of the PR and between 9040d96 and 2fd8714.

⛔ Files ignored due to path filters (2)
  • Gemfile.lock is excluded by !**/*.lock
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • Gemfile
  • package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request updates the Ruby and JavaScript React on Rails dependencies from release candidate versions to 17.1.0.

Changes

Dependency upgrade

Layer / File(s) Summary
React on Rails version updates
Gemfile, package.json
The react_on_rails and react-on-rails dependencies change to version 17.1.0.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: updating React on Rails to version 17.1.0. It matches the dependency updates in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-19T09:21:36.254791Z 2fd8714 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@justin808

Copy link
Copy Markdown
Member Author

🤖 Cursor · Grok 4.6 · medium

Walkthrough for this head: this PR only replaces leftover React on Rails RC pins with the shipped 17.1.0 gems/npm packages (and react-on-rails-rsc 19.3.0 where this app already depended on RSC). Previously the default branch still installed prerelease artifacts after the stable release. Rollback is revert of this commit. Validation is hosted CI plus lockfile pins to 17.1.0.

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The coordinated dependency and lockfile update appears safe to merge.

Summary

This PR updates the Ruby and JavaScript React on Rails packages from the 17.0.0 release candidate to the coordinated 17.1.0 release.

  • Pins react_on_rails and react-on-rails to 17.1.0.
  • Refreshes the corresponding Bundler and Yarn lockfile entries.
  • Keeps the gem and npm package versions aligned.

Reviews (1) · Last reviewed commit: "Pin the demo to the shipped React on Rai..."

@claude

claude Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Gemfile, Gemfile.lock, package.json, yarn.lock) with a focus on code quality, bugs, security, and performance.

Summary: This is a clean, minimal version bump from 17.0.0.rc.6 to 17.1.0 (RC → stable release) for both the react_on_rails gem and npm package. No issues found:

  • Gem and npm package versions are bumped consistently and match between Gemfile/Gemfile.lock and package.json/yarn.lock.
  • Gemfile.lock's react_on_rails (17.1.0) dependency list (addressable, connection_pool, execjs, rails, rainbow, shakapacker) is unchanged, so no transitive dependency drift to worry about.
  • No leftover 17.0.0.rc.6/RC references remain elsewhere in the repo.
  • No security-sensitive code paths are touched — this is purely a lockfile/manifest change.

Minor note (non-blocking): The PR description mentions bumping react-on-rails-rsc to 19.3.0 "where this app already consumed RSC," but this repo doesn't have an react-on-rails-rsc dependency in package.json/Gemfile, and the diff doesn't touch it. Looks like boilerplate carried over from a description template used across multiple repos in this bump — harmless, but worth trimming for clarity.

No code quality, correctness, security, or performance concerns.

@justin808
justin808 merged commit 83c443d into main Sep 19, 2026
3 checks passed
justin808 added a commit that referenced this pull request Oct 15, 2026
* origin/main:
  Bump the javascript group across 1 directory with 14 updates (#30)
  Bump the ruby group across 1 directory with 7 updates (#28)
  Upgrade React on Rails to the 17.2 release candidate (#32)
  Restore validated Shaka policy before the 17.2 upgrade (#31)
  Bump React on Rails to 17.1.0 (#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant